Thanks for review; will move to https://codereview.chromium.org/668143003
for
further discussion.
https://codereview.chromium.org/668663003/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/668663003/diff/1/src/hydrogen.cc#newcode7853
src/hydrogen.cc:7853: target_shared->set_ast_node_count(nodes_added);
On 2014/10/27 13:27:48, Michael Starzinger wrote:
This should now be superseded by
https://codereview.chromium.org/675493002/,
correct?
Yes indeed.
https://codereview.chromium.org/668663003/diff/1/src/hydrogen.cc#newcode7858
src/hydrogen.cc:7858:
target_shared->set_dont_optimize_reason(function->dont_optimize_reason());
On 2014/10/27 13:27:48, Michael Starzinger wrote:
This scares me, could we instead make it go through
SharedFunctionInfo::DisableOptimization?
So this part of the CL is superseded by
https://codereview.chromium.org/668143003, but I guess the comment
applies there too:
https://codereview.chromium.org/668143003/diff/60001/src/compiler.cc
I'll add you to Cc there and fix that patch.
https://codereview.chromium.org/668663003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
