lgtm with nits:
https://codereview.chromium.org/679073002/diff/1/src/type-feedback-vector.cc
File src/type-feedback-vector.cc (right):
https://codereview.chromium.org/679073002/diff/1/src/type-feedback-vector.cc#newcode17
src/type-feedback-vector.cc:17: if (kind == Code::CALL_IC) {
What about using switch?
https://codereview.chromium.org/679073002/diff/1/src/type-feedback-vector.cc#newcode33
src/type-feedback-vector.cc:33: if (kind == KindCallIC)
Same here.
https://codereview.chromium.org/679073002/diff/1/src/utils.h
File src/utils.h (right):
https://codereview.chromium.org/679073002/diff/1/src/utils.h#newcode272
src/utils.h:272: int set_bits = (static_cast<int>(value) <<
shift(item));
Maybe it would be better to call shift() only once.
https://codereview.chromium.org/679073002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
