lgtm.
https://codereview.chromium.org/655833005/diff/1/src/compiler/scheduler.cc
File src/compiler/scheduler.cc (right):
https://codereview.chromium.org/655833005/diff/1/src/compiler/scheduler.cc#newcode960
src/compiler/scheduler.cc:960: // Run the schedule late algorithm on a
set of fixed root nodes.
Do you mean schedule *early* or am I missing something?
https://codereview.chromium.org/655833005/diff/1/src/compiler/scheduler.cc#newcode991
src/compiler/scheduler.cc:991: for (Node::Uses::iterator i =
uses.begin(); i != uses.end(); ++i) {
Just a warning here: in my experience, the uses collection may contain a
lot of junk. Especially with deoptimization on, there might be a bunch
of dead framestates hanging off the uses collection. However, it
possible that Ben's recent work on pruning the graph might help here.
https://codereview.chromium.org/655833005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
