https://codereview.chromium.org/680993003/diff/1/src/x64/full-codegen-x64.cc
File src/x64/full-codegen-x64.cc (right):
https://codereview.chromium.org/680993003/diff/1/src/x64/full-codegen-x64.cc#newcode2428
src/x64/full-codegen-x64.cc:2428: Register scratch = rcx;
On 2014/10/27 21:37:14, Dmitry Lomov (chromium) wrote:
Nit: Why rcx here, but ebx in ia32?
Because I don't know enough about the different registers on the
different platforms. I'll change it.
https://codereview.chromium.org/680993003/diff/1/test/mjsunit/harmony/classes.js
File test/mjsunit/harmony/classes.js (right):
https://codereview.chromium.org/680993003/diff/1/test/mjsunit/harmony/classes.js#newcode180
test/mjsunit/harmony/classes.js:180:
On 2014/10/27 21:37:14, Dmitry Lomov (chromium) wrote:
Additional tests:
1. Test that 'DefineProperty' is not a store (extend a class that has
getter/setter, define method with same name)
I thought I tested that but I guess my tests where just manual tests...
I'll add tests.
2. Test property descriptors of things that are not __proto__.
Will add.
3. Tests with super calls (do I understand correctly though that these
do not
work yet since home object is not installed on methods?)
I was planning on adding that in a follow up CL. I'll expand the CL
descriptions.
https://codereview.chromium.org/680993003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
