Thanks
https://codereview.chromium.org/677953004/diff/1/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/677953004/diff/1/src/preparser.h#newcode1973
src/preparser.h:1973: if (*has_seen_constructor) {
On 2014/10/28 08:30:22, marja wrote:
It's not trivial to see that has_seen_constructor cannot be NULL
here... so the
caller must always pass non-NULL if in_class and !is_static, but
otherwise it's
ok to pass NULL? This is quite subtle. CHECK that this is followed?
Document it
better? Or make this if (has_seen_constructor &&
*has_seen_constructor)? Always
pass a dummy non-NULL ptr? Idk what would be the best solution. Wdyt?
I agree that this is ugly. The least I can do is to add an assert.
https://codereview.chromium.org/677953004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
