lgtm with nits:
https://codereview.chromium.org/680883004/diff/40001/src/ic/ic.cc
File src/ic/ic.cc (right):
https://codereview.chromium.org/680883004/diff/40001/src/ic/ic.cc#newcode545
src/ic/ic.cc:545: reinterpret_cast<CallICNexus*>(nexus));
static_cast?
https://codereview.chromium.org/680883004/diff/40001/src/ic/ic.cc#newcode569
src/ic/ic.cc:569: nexus->ConfigureUninitialized();
Does it make sense to proceed skipping write barriers for Uninitialized
and Generic sentinels?
https://codereview.chromium.org/680883004/diff/40001/src/ic/ic.cc#newcode2091
src/ic/ic.cc:2091: // A miss on a custom call ic always results in going
megamorphic.
This comment can be removed from here.
https://codereview.chromium.org/680883004/diff/40001/src/type-feedback-vector.cc
File src/type-feedback-vector.cc (right):
https://codereview.chromium.org/680883004/diff/40001/src/type-feedback-vector.cc#newcode164
src/type-feedback-vector.cc:164: FixedArray::cast(*feedback)->length()
!= length) {
Do we need to allocate another array if existing one is longer than
requested? Does it make sense to right-trim and reuse the existing one?
https://codereview.chromium.org/680883004/diff/40001/src/type-feedback-vector.cc#newcode227
src/type-feedback-vector.cc:227:
Empty line is missing.
https://codereview.chromium.org/680883004/diff/40001/src/type-feedback-vector.h
File src/type-feedback-vector.h (right):
https://codereview.chromium.org/680883004/diff/40001/src/type-feedback-vector.h#newcode205
src/type-feedback-vector.h:205: void FindAllMaps(MapHandleList* maps)
const { ExtractMaps(maps); }
Do we really need this method? Why not just call ExtractMaps()?
https://codereview.chromium.org/680883004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
