https://codereview.chromium.org/674423002/diff/1/src/isolate.cc
File src/isolate.cc (right):
https://codereview.chromium.org/674423002/diff/1/src/isolate.cc#newcode452
src/isolate.cc:452: error_object,
stack_trace_for_uncaught_exceptions_frame_limit_,
On 2014/10/28 12:08:10, Yang wrote:
There is no need to pass those two arguments, since
GetDetailedStackTraceFromSimpleStack also has access to them on the
Isolate.
Done.
https://codereview.chromium.org/674423002/diff/1/src/isolate.cc#newcode558
src/isolate.cc:558: script->compilation_type() ==
Script::COMPILATION_TYPE_EVAL
On 2014/10/28 12:08:10, Yang wrote:
you can use factory()->ToBoolean for this.
Done.
https://codereview.chromium.org/674423002/diff/1/src/isolate.h
File src/isolate.h (right):
https://codereview.chromium.org/674423002/diff/1/src/isolate.h#newcode750
src/isolate.h:750: Handle<JSArray> GetDetailedStackTraceFromSimpleStack(
On 2014/10/28 12:08:10, Yang wrote:
Naming is a bit weird in the way that you are calling it "SimpleStack"
instead
of "SimpleStackTrace"
Maybe "GetDetailedFromSimpleStackTrace"?
Done.
https://codereview.chromium.org/674423002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
