Can we get some unit tests, either in test-simplified-lowering or
mjsunit/asm/ ?
https://codereview.chromium.org/683873002/diff/1/src/compiler/simplified-lowering.cc
File src/compiler/simplified-lowering.cc (right):
https://codereview.chromium.org/683873002/diff/1/src/compiler/simplified-lowering.cc#newcode654
src/compiler/simplified-lowering.cc:654:
in_upper->Is(Type::Unsigned32()) ||
Something feels a little fishy here. What about making a similar looking
case to the one above like:
if (in_upper->Is(Type::Signed32())) { // existing
...
} else if (in_upper->Is(Type::Unsigned32())) { // new
...
} else if ((in & kTypeMask) == kTypeUint32) { // existing
...
https://codereview.chromium.org/683873002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
