I love simplying stuff. LGTM, just nits.
https://codereview.chromium.org/680313003/diff/20001/src/compiler/common-operator.cc
File src/compiler/common-operator.cc (right):
https://codereview.chromium.org/680313003/diff/20001/src/compiler/common-operator.cc#newcode292
src/compiler/common-operator.cc:292: static inline size_t
CE(Operator::Properties properties) {
Nit: Make this a static private method of class CallOperator. Or move to
Operator class, so that you don't need multiple implementations.
https://codereview.chromium.org/680313003/diff/20001/src/compiler/operator.h
File src/compiler/operator.h (right):
https://codereview.chromium.org/680313003/diff/20001/src/compiler/operator.h#newcode54
src/compiler/operator.h:54: size_t value_in, size_t effect_in, size_t
control_in,
Using size_t here but int for the getters seems inconsistent. Can you
add a TODO?
https://codereview.chromium.org/680313003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
