Addressed comments. Thanks for review. Landing.
https://codereview.chromium.org/685773002/diff/1/src/compiler/scheduler.cc
File src/compiler/scheduler.cc (right):
https://codereview.chromium.org/685773002/diff/1/src/compiler/scheduler.cc#newcode120
src/compiler/scheduler.cc:120: DCHECK_EQ(Scheduler::kCoupled,
data->placement_);
On 2014/10/29 09:22:32, jarin wrote:
We might want to DCHECK that the 'placement' parameter is what it
should be
(kFixed in this case, I believe).
Done. Here and also for the default case below.
https://codereview.chromium.org/685773002/diff/1/src/compiler/scheduler.cc#newcode127
src/compiler/scheduler.cc:127: ++(GetData(control)->unscheduled_count_);
On 2014/10/29 09:22:32, jarin wrote:
Is this here to keep the unscheduled_count above zero? (It seems that
once the
node is kFixed, we never decrement its unscheduled use count.)
As discussed offline: Yes, this is to keep the unscheduled_count above
zero. Unfortunately the control node is not yet marked as kFixed when we
fix the phis. I will work on cleaning up these TODOs next.
https://codereview.chromium.org/685773002/diff/1/src/compiler/scheduler.cc#newcode276
src/compiler/scheduler.cc:276: is_dom &=
!scheduler_->GetData(node->InputAt(i))->is_floating_control_;
On 2014/10/29 09:22:32, jarin wrote:
I really do not like mixing bitwise and bool operators. Could you
rewrite this
to use && or ?: operator?
Done.
https://codereview.chromium.org/685773002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
