lgtm % comments
https://codereview.chromium.org/684103002/diff/60001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/684103002/diff/60001/include/v8.h#newcode2967
include/v8.h:2967: * ArrayBuffer should have been externalized and must
be neuterable.
Add Utils::ApiCheck for this to v8::ArrayBuffer::Neuter.
https://codereview.chromium.org/684103002/diff/60001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/684103002/diff/60001/src/objects.cc#newcode16368
src/objects.cc:16368: DCHECK(is_neuterable());
Change to CHECK - this should fail in release as well.
(feel free to change DCHECK to CHECK in DCHECK(is_external()) below)
https://codereview.chromium.org/684103002/diff/60001/src/objects.cc#newcode16376
src/objects.cc:16376:
DCHECK(JSArrayBuffer::cast(buffer())->is_neuterable());
Change to CHECK - this should fail in release as well.
https://codereview.chromium.org/684103002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
