Looking good. Please add tests for:
- compilation cache doesn't keep SFI and code alive after N GCs,
- Put(x); Lookup(x) == undefined;
- Put(x); Put(x); Lookup(x) == x;
- Put(x); 10 * Age(); Put(x); Lookup(x) == undefined;
https://codereview.chromium.org/675013004/diff/20001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/675013004/diff/20001/src/objects.h#newcode7940
src/objects.h:7940: class CompilationCacheTable: public
HashTable<CompilationCacheTable,
Could you please add few words describing state changes of (key, value)
entry with put, age, and lookup operations?
https://codereview.chromium.org/675013004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
