Guys, that buys us a nice speed up in Dromaeo: http://dromaeo.com/?id=74679,74680 (patched version is 74680). I was surprised to see it slightly slows down accessors (I suspect it's just a matter of fast case, would investigate).
My main concern is if it is too test specific: yes, JSC special cases appending a single character, but they do it on string concatenation as they have no notion of flattening. Maybe we should just flatten fastly any flat second of cons. However, as I miss real data about string shapes (would launch on golem, but I am not sure it exercises Write at all) I decided to go with the simplest things---it's rather easy to adjust if we find where we fail. Ivan, what's your external account I should use for reviews? yours, anton. On Tue, Sep 29, 2009 at 11:52 AM, <[email protected]> wrote: > http://codereview.chromium.org/248031 > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
