Reviewers: Erik Corry, Description: Compile without debugger support in debug mode
This makes it possible to build V8 without JavaScript debugging support in debug mode. BUG=454 Please review this at http://codereview.chromium.org/242048 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/ia32/codegen-ia32.cc M src/objects.h Index: src/ia32/codegen-ia32.cc =================================================================== --- src/ia32/codegen-ia32.cc (revision 2982) +++ src/ia32/codegen-ia32.cc (working copy) @@ -2543,10 +2543,12 @@ masm_->ret((scope_->num_parameters() + 1) * kPointerSize); DeleteFrame(); +#ifdef ENABLE_DEBUGGER_SUPPORT // Check that the size of the code used for returning matches what is // expected by the debugger. ASSERT_EQ(Debug::kIa32JSReturnSequenceLength, masm_->SizeOfCodeGeneratedSince(&check_exit_codesize)); +#endif } Index: src/objects.h =================================================================== --- src/objects.h (revision 2982) +++ src/objects.h (working copy) @@ -211,7 +211,7 @@ // NOTE: Everything following JS_VALUE_TYPE is considered a // JSObject for GC purposes. The first four entries here have typeof // 'object', whereas JS_FUNCTION_TYPE has typeof 'function'. -#define INSTANCE_TYPE_LIST(V) \ +#define INSTANCE_TYPE_LIST_ALL(V) \ V(SHORT_SYMBOL_TYPE) \ V(MEDIUM_SYMBOL_TYPE) \ V(LONG_SYMBOL_TYPE) \ @@ -282,8 +282,6 @@ V(OBJECT_TEMPLATE_INFO_TYPE) \ V(SIGNATURE_INFO_TYPE) \ V(TYPE_SWITCH_INFO_TYPE) \ - V(DEBUG_INFO_TYPE) \ - V(BREAK_POINT_INFO_TYPE) \ V(SCRIPT_TYPE) \ \ V(JS_VALUE_TYPE) \ @@ -297,8 +295,19 @@ \ V(JS_FUNCTION_TYPE) \ +#ifdef ENABLE_DEBUGGER_SUPPORT +#define INSTANCE_TYPE_LIST_DEBUGGER(V) \ + V(DEBUG_INFO_TYPE) \ + V(BREAK_POINT_INFO_TYPE) +#else +#define INSTANCE_TYPE_LIST_DEBUGGER(V) +#endif +#define INSTANCE_TYPE_LIST(V) \ + INSTANCE_TYPE_LIST_ALL(V) \ + INSTANCE_TYPE_LIST_DEBUGGER(V) + // Since string types are not consecutive, this macro is used to // iterate over them. #define STRING_TYPE_LIST(V) \ @@ -673,8 +682,10 @@ OBJECT_TEMPLATE_INFO_TYPE, SIGNATURE_INFO_TYPE, TYPE_SWITCH_INFO_TYPE, +#ifdef ENABLE_DEBUGGER_SUPPORT DEBUG_INFO_TYPE, BREAK_POINT_INFO_TYPE, +#endif SCRIPT_TYPE, JS_VALUE_TYPE, --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
