Reviewers: Toon Verwaest, danno, dcarney,
Message:
In the binding side, the jit hint can be set as below:
v8::Local<v8::Accessor> ac = instanceTemplate->SetAccessorEx(...)
if (!ac.IsEmpty()) ac->setOptimizeLevel(v8::Accessor::kOptimizeInline);
Could you help to review it? and thanks very much for any of your comments.
Description:
Optimized nodeType dom binding by removing HandleScope and the preparation
of
ordinary c function call.
In nodeType getter callback, it does not New objects, so it's
safe to remove HandleScope().
And in ordinary C function, it create a new frame(push ebp/pop ebp)
to store arguments. But for some straightforward getter, like
nodeTypeAttributeGetter, By removing this preparation, it can improve
nodeType api performance by 30%.
BUG=v8:3667
Please review this at https://codereview.chromium.org/697603002/
Base URL: https://chromium.googlesource.com/external/v8.git@master
Affected files (+241, -3 lines):
M include/v8.h
M src/api.h
M src/api.cc
M src/code-stubs.h
M src/ic/x64/handler-compiler-x64.cc
M src/objects.h
M src/objects-inl.h
M src/x64/code-stubs-x64.cc
M src/x64/macro-assembler-x64.h
M src/x64/macro-assembler-x64.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
