Revision: 25027
Author: [email protected]
Date: Fri Oct 31 09:19:55 2014 UTC
Log: X64: replace explicit zero-extend with runtime assert
Since the input float64 is in the range of [0, 2^32-1], the upper 32 bits
of output register
should be zero.
BUG=
[email protected], [email protected]
Review URL: https://codereview.chromium.org/644993002
Patch from Weiliang Lin <[email protected]>.
https://code.google.com/p/v8/source/detail?r=25027
Modified:
/branches/bleeding_edge/src/compiler/x64/code-generator-x64.cc
=======================================
--- /branches/bleeding_edge/src/compiler/x64/code-generator-x64.cc Fri Oct
31 06:41:07 2014 UTC
+++ /branches/bleeding_edge/src/compiler/x64/code-generator-x64.cc Fri Oct
31 09:19:55 2014 UTC
@@ -441,16 +441,15 @@
__ cvttsd2si(i.OutputRegister(), i.InputOperand(0));
}
break;
- case kSSEFloat64ToUint32:
+ case kSSEFloat64ToUint32: {
if (instr->InputAt(0)->IsDoubleRegister()) {
__ cvttsd2siq(i.OutputRegister(), i.InputDoubleRegister(0));
} else {
__ cvttsd2siq(i.OutputRegister(), i.InputOperand(0));
}
- __ andl(i.OutputRegister(), i.OutputRegister()); // clear upper
bits.
- // TODO(turbofan): generated code should not look at the upper 32
bits
- // of the result, but those bits could escape to the outside world.
+ __ AssertZeroExtended(i.OutputRegister());
break;
+ }
case kSSEInt32ToFloat64:
if (instr->InputAt(0)->IsRegister()) {
__ cvtlsi2sd(i.OutputDoubleRegister(), i.InputRegister(0));
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
