PTAL
https://codereview.chromium.org/652743009/diff/60001/src/parser.h
File src/parser.h (right):
https://codereview.chromium.org/652743009/diff/60001/src/parser.h#newcode856
src/parser.h:856: return identifier->IsOneByteEqualTo("let") ||
On 2014/10/31 10:16:04, rossberg wrote:
Is there a reason we cannot fold these into the scanner's
IdentifierIsFutureStrictReserved?
Done.
https://codereview.chromium.org/652743009/diff/60001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/652743009/diff/60001/test/cctest/test-parsing.cc#newcode1831
test/cctest/test-parsing.cc:1831: "function " #NAME "() { }",
\
On 2014/10/31 10:16:04, rossberg wrote:
Maybe add a function expression as well.
Done.
https://codereview.chromium.org/652743009/diff/60001/test/cctest/test-parsing.cc#newcode1834
test/cctest/test-parsing.cc:1834: #NAME " = 1;",
\
On 2014/10/31 10:16:04, rossberg wrote:
Perhaps also add a "+=" case.
Done.
https://codereview.chromium.org/652743009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
