Right on, LGTM. Couple nits.
https://codereview.chromium.org/686103004/diff/1/src/heap/spaces.h
File src/heap/spaces.h (right):
https://codereview.chromium.org/686103004/diff/1/src/heap/spaces.h#newcode1107
src/heap/spaces.h:1107: static int PageAreaSize(AllocationSpace space) {
How about a DCHECK that space isn't LO_SPACE.
https://codereview.chromium.org/686103004/diff/1/src/serialize.cc
File src/serialize.cc (right):
https://codereview.chromium.org/686103004/diff/1/src/serialize.cc#newcode1937
src/serialize.cc:1937: // The non-branching GetInt will read up to 3
bytes too far, so we need
Could you add some variant of this comment to the Pad(); declaration in
the header file?
https://codereview.chromium.org/686103004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
