On 2014/10/31 12:28:06, Michael Starzinger wrote:
Looking good, just one suggestion.
https://codereview.chromium.org/694773002/diff/1/src/compiler/js-generic-lowering.cc
File src/compiler/js-generic-lowering.cc (right):
https://codereview.chromium.org/694773002/diff/1/src/compiler/js-generic-lowering.cc#newcode427
src/compiler/js-generic-lowering.cc:427: if (func.HasValue()) {
suggestion: How would you feel about moving this optimization into a
separate
helper? That way it would visually be clear that this is an optional
optimization, a comment in that regard might also be nice/
Done.
https://codereview.chromium.org/694773002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
