Reviewers: Benedikt Meurer,
Message:
Could you take a look, please?
Description:
[turbofan] Fix Typer::Rangify to handle integral bitset types.
[email protected]
BUG=
Please review this at https://codereview.chromium.org/688413003/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+12, -3 lines):
M src/compiler/typer.cc
Index: src/compiler/typer.cc
diff --git a/src/compiler/typer.cc b/src/compiler/typer.cc
index
3649f7d79dcd4c1bf7f0699c92b9c9d512364fed..d7faa5a855b9b7134d651f599f904402b9532a47
100644
--- a/src/compiler/typer.cc
+++ b/src/compiler/typer.cc
@@ -408,10 +408,19 @@ Type* Typer::Visitor::FalsifyUndefined(Type* type,
Typer* t) {
Type* Typer::Visitor::Rangify(Type* type, Typer* t) {
if (type->IsRange()) return type; // Shortcut.
- if (!type->Is(t->integer)) return type; // Give up.
+ if (!type->Is(t->integer) && !type->Is(Type::Integral32())) {
+ return type; // Give up on non-integer types.
+ }
+ double min = type->Min();
+ double max = type->Max();
+ // Handle the degenerate case of empty bitset types (such as
+ // OtherUnsigned31 and OtherSigned32 on 64-bit architectures).
+ if (std::isnan(min)) {
+ DCHECK(std::isnan(max));
+ return type;
+ }
Factory* f = t->isolate()->factory();
- return Type::Range(f->NewNumber(type->Min()), f->NewNumber(type->Max()),
- t->zone());
+ return Type::Range(f->NewNumber(min), f->NewNumber(max), t->zone());
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
