Apart from that one comment it LGTM, and I'm annoyed with myself for not suggesting this in response to the first patch you sent out!
http://codereview.chromium.org/255004/diff/2001/3001 File src/api.cc (right): http://codereview.chromium.org/255004/diff/2001/3001#newcode2454 Line 2454: if (end < length) Seems like this version doesn't put a trailing null on if the length is -1, whereas the old version did. http://codereview.chromium.org/255004 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
