Reviewers: tandrii,
Message:
PTAL
Description:
Fix auto roll update.
Auto roll requires an additional "git fetch" now that it uses
a workdir. Before, the checkout used to be updated
externally.
BUG=408523
LOG=n
TEST=script_test.py
TBR=tand...@chromium.org
Please review this at https://codereview.chromium.org/695323002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+5, -0 lines):
M tools/push-to-trunk/auto_roll.py
M tools/push-to-trunk/test_scripts.py
Index: tools/push-to-trunk/auto_roll.py
diff --git a/tools/push-to-trunk/auto_roll.py
b/tools/push-to-trunk/auto_roll.py
index
00f45e04099f36949f7b548631d42359a1e266c1..1b57097cde8d93048b4719e33b85f1eda49831f5
100755
--- a/tools/push-to-trunk/auto_roll.py
+++ b/tools/push-to-trunk/auto_roll.py
@@ -42,6 +42,7 @@ class DetectLastPush(Step):
MESSAGE = "Detect commit ID of the last push to trunk."
def RunStep(self):
+ self.vc.Fetch()
push_hash = self.FindLastTrunkPush(
branch="origin/candidates", include_patches=True)
self["last_push"] = self.GetCommitPositionNumber(push_hash)
Index: tools/push-to-trunk/test_scripts.py
diff --git a/tools/push-to-trunk/test_scripts.py
b/tools/push-to-trunk/test_scripts.py
index
6d1aec5af9ef92506f8e8105399fe1d7f92b1c8b..f31c491dc0cee533869ab8bb1eb5efc2837286be
100644
--- a/tools/push-to-trunk/test_scripts.py
+++ b/tools/push-to-trunk/test_scripts.py
@@ -1178,6 +1178,8 @@ deps = {
URL("https://codereview.chromium.org/search";,
"owner=author%40chromium.org&limit=30&closed=3&format=json",
("{\"results\": [{\"subject\": \"different\"}]}")),
+ Cmd("git fetch", ""),
+ Cmd("git svn fetch", ""),
Cmd(("git log -1 --format=%H --grep="
"\"^Version [[:digit:]]*\.[[:digit:]]*\.[[:digit:]]*\" "
"origin/candidates"), "push_hash\n"),
@@ -1199,6 +1201,8 @@ deps = {
URL("https://codereview.chromium.org/search";,
"owner=author%40chromium.org&limit=30&closed=3&format=json",
("{\"results\": [{\"subject\": \"different\"}]}")),
+ Cmd("git fetch", ""),
+ Cmd("git svn fetch", ""),
Cmd(("git log -1 --format=%H --grep="
"\"^Version [[:digit:]]*\.[[:digit:]]*\.[[:digit:]]*\" "
"origin/candidates"), "push_hash\n"),
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
