On 2014/11/03 17:16:43, Michael Starzinger wrote:
LGTM (mostly rubber-stamped).
https://codereview.chromium.org/652263002/diff/20001/test/cctest/compiler/test-graph-visualizer.cc
File test/cctest/compiler/test-graph-visualizer.cc (right):
https://codereview.chromium.org/652263002/diff/20001/test/cctest/compiler/test-graph-visualizer.cc#newcode87
test/cctest/compiler/test-graph-visualizer.cc:87: phi->ReplaceInput(1,
NULL);
nit: It doesn't seem like this phi is reachable from start. Maybe use a
Merge
instead if a Phi here.
Done.
https://codereview.chromium.org/652263002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
