Reviewers: Dmitry Lomov (chromium),
Description:
Fix a few nits found by PVS Studio
BUG=v8:3192
LOG=n
Please review this at https://codereview.chromium.org/185563004/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+13, -16 lines):
M src/deoptimizer.cc
M src/hydrogen.cc
M src/objects.cc
M src/parser.cc
M test/cctest/test-api.cc
M test/cctest/test-strings.cc
Index: src/deoptimizer.cc
diff --git a/src/deoptimizer.cc b/src/deoptimizer.cc
index
467931c04a5c94f5211f90ab696453846a0724fc..554ba8e7b17f272e5f4dbfbad51df460343bcc8a
100644
--- a/src/deoptimizer.cc
+++ b/src/deoptimizer.cc
@@ -693,8 +693,7 @@ int Deoptimizer::GetDeoptimizationId(Isolate* isolate,
DeoptimizerData* data = isolate->deoptimizer_data();
MemoryChunk* base = data->deopt_entry_code_[type];
Address start = base->area_start();
- if (base == NULL ||
- addr < start ||
+ if (addr < start ||
addr >= start + (kMaxNumberOfEntries * table_entry_size_)) {
return kNotDeoptimizationEntry;
}
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index
9dab15565b633ae770efcca6d302546b6a86c7ab..31fcd4ca46549f5adc575766f2dce2ec90186da1
100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -12643,9 +12643,10 @@ void HStatistics::Print() {
double normalized_time = source_size_in_kb > 0
? total.InMillisecondsF() / source_size_in_kb
: 0;
- double normalized_size_in_kb = source_size_in_kb > 0
- ? total_size_ / 1024 / source_size_in_kb
- : 0;
+ double normalized_size_in_kb =
+ source_size_in_kb > 0
+ ? static_cast<double>(total_size_) / 1024 / source_size_in_kb
+ : 0;
PrintF("%33s %8.3f ms %7.3f kB allocated\n",
"Average per kB source", normalized_time, normalized_size_in_kb);
}
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index
74a16baa340fd46bf81554f510a0ee457e8341c9..9933e9c61497c8d3307ea4643cc96b65bc0eca07
100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -7197,7 +7197,7 @@ class IntrusiveMapTransitionIterator {
int value = Smi::cast(*IteratorField())->value();
int index = -value - 1;
int number_of_transitions = transition_array_->number_of_transitions();
- while (index < number_of_transitions) {
+ if (index < number_of_transitions) {
*IteratorField() = Smi::FromInt(value - 1);
return transition_array_->GetTarget(index);
}
Index: src/parser.cc
diff --git a/src/parser.cc b/src/parser.cc
index
ab9d6b7e5b00b75c452454b6d35ac28a7ccc04fe..c5bf0d977708df914299099f36f197a0e5b55eca
100644
--- a/src/parser.cc
+++ b/src/parser.cc
@@ -3203,7 +3203,7 @@ Statement* Parser::ParseForStatement(ZoneList<const
AstRawString*>* labels,
Scanner::Location lhs_location = scanner()->peek_location();
Expression* expression = ParseExpression(false, CHECK_OK);
ForEachStatement::VisitMode mode;
- bool accept_OF = expression->AsVariableProxy();
+ bool accept_OF = expression->IsVariableProxy();
if (CheckInOrOf(accept_OF, &mode)) {
expression = this->CheckAndRewriteReferenceExpression(
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index
fc74a42d1e2d99d4637570a3b2be706808c4ac24..0e6d1282d6644ed70d539bec71fa8c222f351ded
100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -15148,7 +15148,7 @@ THREADED_TEST(PropertyEnumeration2) {
v8::Handle<v8::Array> props = val.As<v8::Object>()->GetPropertyNames();
CHECK_EQ(0, props->Length());
for (uint32_t i = 0; i < props->Length(); i++) {
- printf("p[%d]\n", i);
+ printf("p[%u]\n", i);
}
}
Index: test/cctest/test-strings.cc
diff --git a/test/cctest/test-strings.cc b/test/cctest/test-strings.cc
index
76c1612c8742e2bf5006bee64bc50652a55b8b35..e01c7670346df70aacd7b4820259aa58062552ea
100644
--- a/test/cctest/test-strings.cc
+++ b/test/cctest/test-strings.cc
@@ -630,14 +630,11 @@ static void VerifyCharacterStream(
static inline void PrintStats(const ConsStringGenerationData& data) {
#ifdef DEBUG
-printf(
- "%s: [%d], %s: [%d], %s: [%d], %s: [%d], %s: [%d], %s: [%d]\n",
- "leaves", data.stats_.leaves_,
- "empty", data.stats_.empty_leaves_,
- "chars", data.stats_.chars_,
- "lefts", data.stats_.left_traversals_,
- "rights", data.stats_.right_traversals_,
- "early_terminations", data.early_terminations_);
+ printf("%s: [%u], %s: [%u], %s: [%u], %s: [%u], %s: [%u], %s: [%u]\n",
+ "leaves", data.stats_.leaves_, "empty", data.stats_.empty_leaves_,
+ "chars", data.stats_.chars_, "lefts",
data.stats_.left_traversals_,
+ "rights", data.stats_.right_traversals_, "early_terminations",
+ data.early_terminations_);
#endif
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
