https://codereview.chromium.org/661133002/diff/80001/src/transitions-inl.h
File src/transitions-inl.h (right):
https://codereview.chromium.org/661133002/diff/80001/src/transitions-inl.h#newcode217
src/transitions-inl.h:217: DCHECK_NE(kNotFound, descriptor);
Mmh, this doesn't seem necessary. We shouldn't need to compare details
ever when you can't find it at the end. This is only true if you added a
setter/getter to an existing setter/getter. In such case, that's the
only possible transition under that name. If we are fetching such
details, we're probably computing too much stuff.
https://codereview.chromium.org/661133002/diff/80001/src/transitions.cc
File src/transitions.cc (right):
https://codereview.chromium.org/661133002/diff/80001/src/transitions.cc#newcode199
src/transitions.cc:199: for (;;) {
for ( ; transition < nof_transitions && GetKey(transition) == key;
transition++) ?
https://codereview.chromium.org/661133002/diff/80001/src/transitions.h
File src/transitions.h (right):
https://codereview.chromium.org/661133002/diff/80001/src/transitions.h#newcode223
src/transitions.h:223: // 0 if set1 equal to set2 and 1 otherwise.
Sets? It just compares 2 keys with extra info than just the name...
https://codereview.chromium.org/661133002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
