LGTM, but please fix the nit.
https://codereview.chromium.org/700873002/diff/1/src/compiler/mips/code-generator-mips.cc
File src/compiler/mips/code-generator-mips.cc (right):
https://codereview.chromium.org/700873002/diff/1/src/compiler/mips/code-generator-mips.cc#newcode243
src/compiler/mips/code-generator-mips.cc:243: // Psuedo-instruction used
for tst/branch.
Suggest adding "No opcode emitted here." to comment, as below.
Please either add back the 'break' or put in a comment: // Fall-through.
I don't think either approach will significantly change the generated
code, so it probably best to use explicit break.
https://codereview.chromium.org/700873002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
