Reviewers: Sven Panne,
Description:
[turbofan] Fix missing machine type for float32/float64 array accesses.
TEST=mjsunit/asm
[email protected]
Please review this at https://codereview.chromium.org/703883002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+34, -2 lines):
M src/compiler/access-builder.cc
A test/mjsunit/asm/float32array-store-div.js
A test/mjsunit/asm/float64array-store-div.js
Index: src/compiler/access-builder.cc
diff --git a/src/compiler/access-builder.cc b/src/compiler/access-builder.cc
index
2c270220df88fdac27c95dd00f9868a0d4d2b0de..583bd3aaaf5349f41174bed796642a95cef35d5e
100644
--- a/src/compiler/access-builder.cc
+++ b/src/compiler/access-builder.cc
@@ -106,10 +106,10 @@ ElementAccess
AccessBuilder::ForTypedArrayElement(ExternalArrayType type,
Type::Unsigned32(), kMachUint32};
case kExternalFloat32Array:
return {kTypedArrayBoundsCheck, taggedness, header_size,
Type::Number(),
- kRepFloat32};
+ kMachFloat32};
case kExternalFloat64Array:
return {kTypedArrayBoundsCheck, taggedness, header_size,
Type::Number(),
- kRepFloat64};
+ kMachFloat64};
}
UNREACHABLE();
return {kTypedArrayBoundsCheck, kUntaggedBase, 0, Type::None(),
kMachNone};
Index: test/mjsunit/asm/float32array-store-div.js
diff --git a/test/mjsunit/asm/float32array-store-div.js
b/test/mjsunit/asm/float32array-store-div.js
new file mode 100644
index
0000000000000000000000000000000000000000..78224f962b7971f2b86a5381e98e2bbd2c63ca13
--- /dev/null
+++ b/test/mjsunit/asm/float32array-store-div.js
@@ -0,0 +1,16 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+function Module(stdlib, foreign, heap) {
+ "use asm";
+ var MEM32 = new stdlib.Float32Array(heap);
+ function foo(i) {
+ MEM32[0] = (i >>> 0) / 2;
+ return MEM32[0];
+ }
+ return { foo: foo };
+}
+
+var foo = Module(this, {}, new ArrayBuffer(64 * 1024)).foo;
+assertEquals(0.5, foo(1));
Index: test/mjsunit/asm/float64array-store-div.js
diff --git a/test/mjsunit/asm/float64array-store-div.js
b/test/mjsunit/asm/float64array-store-div.js
new file mode 100644
index
0000000000000000000000000000000000000000..10b0011fbc41c083af0144deda068f576f074a5b
--- /dev/null
+++ b/test/mjsunit/asm/float64array-store-div.js
@@ -0,0 +1,16 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+function Module(stdlib, foreign, heap) {
+ "use asm";
+ var MEM64 = new stdlib.Float64Array(heap);
+ function foo(i) {
+ MEM64[0] = (i >>> 0) / 2;
+ return MEM64[0];
+ }
+ return { foo: foo };
+}
+
+var foo = Module(this, {}, new ArrayBuffer(64 * 1024)).foo;
+assertEquals(0.5, foo(1));
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
