Revision: 25128
Author: [email protected]
Date: Wed Nov 5 08:15:09 2014 UTC
Log: [turbofan] Fix missing machine type for float32/float64 array
accesses.
TEST=mjsunit/asm
[email protected]
Review URL: https://codereview.chromium.org/703883002
https://code.google.com/p/v8/source/detail?r=25128
Added:
/branches/bleeding_edge/test/mjsunit/asm/float32array-store-div.js
/branches/bleeding_edge/test/mjsunit/asm/float64array-store-div.js
Modified:
/branches/bleeding_edge/src/compiler/access-builder.cc
=======================================
--- /dev/null
+++ /branches/bleeding_edge/test/mjsunit/asm/float32array-store-div.js Wed
Nov 5 08:15:09 2014 UTC
@@ -0,0 +1,16 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+function Module(stdlib, foreign, heap) {
+ "use asm";
+ var MEM32 = new stdlib.Float32Array(heap);
+ function foo(i) {
+ MEM32[0] = (i >>> 0) / 2;
+ return MEM32[0];
+ }
+ return { foo: foo };
+}
+
+var foo = Module(this, {}, new ArrayBuffer(64 * 1024)).foo;
+assertEquals(0.5, foo(1));
=======================================
--- /dev/null
+++ /branches/bleeding_edge/test/mjsunit/asm/float64array-store-div.js Wed
Nov 5 08:15:09 2014 UTC
@@ -0,0 +1,16 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+function Module(stdlib, foreign, heap) {
+ "use asm";
+ var MEM64 = new stdlib.Float64Array(heap);
+ function foo(i) {
+ MEM64[0] = (i >>> 0) / 2;
+ return MEM64[0];
+ }
+ return { foo: foo };
+}
+
+var foo = Module(this, {}, new ArrayBuffer(64 * 1024)).foo;
+assertEquals(0.5, foo(1));
=======================================
--- /branches/bleeding_edge/src/compiler/access-builder.cc Tue Oct 28
08:33:52 2014 UTC
+++ /branches/bleeding_edge/src/compiler/access-builder.cc Wed Nov 5
08:15:09 2014 UTC
@@ -106,10 +106,10 @@
Type::Unsigned32(), kMachUint32};
case kExternalFloat32Array:
return {kTypedArrayBoundsCheck, taggedness, header_size,
Type::Number(),
- kRepFloat32};
+ kMachFloat32};
case kExternalFloat64Array:
return {kTypedArrayBoundsCheck, taggedness, header_size,
Type::Number(),
- kRepFloat64};
+ kMachFloat64};
}
UNREACHABLE();
return {kTypedArrayBoundsCheck, kUntaggedBase, 0, Type::None(),
kMachNone};
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
