Reviewers: jarin,
Description:
Version 3.28.71.19 (merged r23127)
Remove the flaky store buffer test for maps.
[email protected]
BUG=
Please review this at https://codereview.chromium.org/692013003/
Base URL: https://v8.googlecode.com/svn/branches/3.28
Affected files (+1, -46 lines):
M src/version.cc
M test/cctest/test-heap.cc
Index: src/version.cc
diff --git a/src/version.cc b/src/version.cc
index
3f52f97ccf96f004d82231944e283d43462b9759..28b9de3a7a98046225e7fb52f29db01ccb8f0044
100644
--- a/src/version.cc
+++ b/src/version.cc
@@ -35,7 +35,7 @@
#define MAJOR_VERSION 3
#define MINOR_VERSION 28
#define BUILD_NUMBER 71
-#define PATCH_LEVEL 18
+#define PATCH_LEVEL 19
// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
#define IS_CANDIDATE_VERSION 0
Index: test/cctest/test-heap.cc
diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc
index
601e9eb715ab36b0cfdf32fffb02d42978cfdc29..ab000dc6a6ee28f1ebc78b491db3a630074e9b18
100644
--- a/test/cctest/test-heap.cc
+++ b/test/cctest/test-heap.cc
@@ -4475,51 +4475,6 @@ TEST(Regress388880) {
}
-TEST(RegressStoreBufferMapUpdate) {
- CcTest::InitializeVM();
- v8::HandleScope scope(CcTest::isolate());
- Isolate* isolate = CcTest::i_isolate();
- Factory* factory = isolate->factory();
- Heap* heap = isolate->heap();
-
- // This test checks that we do not treat instance size field of the map
- // as a heap pointer when processing the store buffer.
-
- Handle<Map> map1 = Map::Create(isolate->object_function(), 1);
-
- // Allocate a throw-away object.
- factory->NewFixedArray(1, NOT_TENURED);
-
- // Allocate a new-space object that will be moved by the GC (because
- // the throw-away object will die).
- Handle<FixedArray> object_to_move = factory->NewFixedArray(1,
NOT_TENURED);
-
- // Record the address before the GC.
- Object* object_to_move_address = *object_to_move;
-
- // Smash the new space pointer to the moving object into the instance
size
- // field of the map. The idea is to trick the GC into updating this
pointer
- // when the object moves. This would be wrong because instance size
should
- // not be treated as a heap pointer.
- *(reinterpret_cast<Object**>(map1->address() +
Map::kInstanceSizeOffset)) =
- object_to_move_address;
-
- // Make sure we scan the map's page on scavenge.
- Page* page = Page::FromAddress(map1->address());
- page->set_scan_on_scavenge(true);
-
- heap->CollectGarbage(NEW_SPACE);
-
- // Check the object has really moved.
- CHECK(*object_to_move != object_to_move_address);
-
- // Now check that we have not updated the instance size field of the map.
- CHECK_EQ(object_to_move_address,
- *(reinterpret_cast<Object**>(map1->address() +
- Map::kInstanceSizeOffset)));
-}
-
-
#ifdef DEBUG
TEST(PathTracer) {
CcTest::InitializeVM();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
