Thanks for the review. Addressed comments. Landing.
https://codereview.chromium.org/696363002/diff/40001/src/compiler/scheduler.cc
File src/compiler/scheduler.cc (right):
https://codereview.chromium.org/696363002/diff/40001/src/compiler/scheduler.cc#newcode676
src/compiler/scheduler.cc:676: BlockList* insert_tail = insert_head ==
NULL ? NULL : insert_head->next;
On 2014/11/04 20:58:29, jarin wrote:
The names are a bit confusing, I think. How about insert_after and
insert_before?
Done.
https://codereview.chromium.org/696363002/diff/40001/src/compiler/scheduler.cc#newcode721
src/compiler/scheduler.cc:721: insert_head->next = insert_tail->next;
On 2014/11/04 20:58:29, jarin wrote:
Hmm, should not it be 'insert_head->next = insert_tail;' ?
That's because there are two list element for the "entry" block. One
already in the original list and one in the newly created sub-list. I
agree this is confusing. I added an assertion in that regard and a
comment explaining it.
https://codereview.chromium.org/696363002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
