Reviewers: Benedikt Meurer, Igor Sheludko,
Message:
PTAL
Description:
Add fast-variants feature to test driver.
BUG=
Please review this at https://codereview.chromium.org/704723002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+11, -6 lines):
M test/mjsunit/mjsunit.status
M tools/testrunner/local/statusfile.py
M tools/testrunner/local/testsuite.py
Index: test/mjsunit/mjsunit.status
diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status
index
6b3cf844ca251b9cc68e615bae86a5a476131ecd..723f0e8c8de4e89e16f3dda89ea292cd30c9609b
100644
--- a/test/mjsunit/mjsunit.status
+++ b/test/mjsunit/mjsunit.status
@@ -31,11 +31,6 @@
'bugs/*': [FAIL],
##############################################################################
- # Slow tests.
- 'asm/embenchen/box2d': [PASS, SLOW],
- 'asm/embenchen/lua_binarytrees': [PASS, SLOW],
-
-
##############################################################################
# Flaky tests.
# BUG(v8:2921).
'debug-step-4-in-frame': [PASS, FAIL, SLOW],
@@ -205,6 +200,9 @@
# This test variant makes only sense on arm.
'math-floor-of-div-nosudiv': [PASS, SLOW, ['arch not in [arm, arm64,
android_arm, android_arm64]', SKIP]],
+
+ # Too slow for slow variants.
+ 'asm/embenchen/*': [PASS, FAST_VARIANTS]
}], # ALWAYS
##############################################################################
Index: tools/testrunner/local/statusfile.py
diff --git a/tools/testrunner/local/statusfile.py
b/tools/testrunner/local/statusfile.py
index
7c3ca7fb51bc5ca7a05a74d5847a19c260eef019..a313f0509fe08fc0f6e3327306375015ffe38032
100644
--- a/tools/testrunner/local/statusfile.py
+++ b/tools/testrunner/local/statusfile.py
@@ -35,6 +35,7 @@ TIMEOUT = "TIMEOUT"
CRASH = "CRASH"
SLOW = "SLOW"
FLAKY = "FLAKY"
+FAST_VARIANTS = "FAST_VARIANTS"
NO_VARIANTS = "NO_VARIANTS"
# These are just for the status files and are mapped below in DEFS:
FAIL_OK = "FAIL_OK"
@@ -44,7 +45,7 @@ ALWAYS = "ALWAYS"
KEYWORDS = {}
for key in [SKIP, FAIL, PASS, OKAY, TIMEOUT, CRASH, SLOW, FLAKY, FAIL_OK,
- NO_VARIANTS, PASS_OR_FAIL, ALWAYS]:
+ FAST_VARIANTS, NO_VARIANTS, PASS_OR_FAIL, ALWAYS]:
KEYWORDS[key] = key
DEFS = {FAIL_OK: [FAIL, OKAY],
@@ -70,6 +71,10 @@ def OnlyStandardVariant(outcomes):
return NO_VARIANTS in outcomes
+def OnlyFastVariants(outcomes):
+ return FAST_VARIANTS in outcomes
+
+
def IsFlaky(outcomes):
return FLAKY in outcomes
Index: tools/testrunner/local/testsuite.py
diff --git a/tools/testrunner/local/testsuite.py
b/tools/testrunner/local/testsuite.py
index
148697bfde7506e630baf53105dd06b59e7e5628..24161f388862b757338faa23e890b8562fdf1585
100644
--- a/tools/testrunner/local/testsuite.py
+++ b/tools/testrunner/local/testsuite.py
@@ -81,6 +81,8 @@ class TestSuite(object):
def VariantFlags(self, testcase, default_flags):
if testcase.outcomes and
statusfile.OnlyStandardVariant(testcase.outcomes):
return [[]]
+ if testcase.outcomes and
statusfile.OnlyFastVariants(testcase.outcomes):
+ return filter(lambda v: v in ["default", "turbofan"], default_flags)
return default_flags
def DownloadData(self):
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
