https://codereview.chromium.org/694703003/diff/20001/src/base/atomicops_internals_mac.h
File src/base/atomicops_internals_mac.h (right):
https://codereview.chromium.org/694703003/diff/20001/src/base/atomicops_internals_mac.h#newcode83
src/base/atomicops_internals_mac.h:83: ATOMICOPS_COMPILER_BARRIER();
On 2014/11/05 11:54:53, jarin wrote:
I think it is better not to touch anything else than AcquireLoad
because the
semantics of that is not completely clear.
Done. However, I would also change the release stores. WDYT?
https://codereview.chromium.org/694703003/diff/20001/src/base/atomicops_internals_mac.h#newcode101
src/base/atomicops_internals_mac.h:101: ATOMICOPS_COMPILER_BARRIER();
On 2014/11/05 11:54:53, jarin wrote:
How about just saying here
// On x86 processors, loads already have acquire semantics, so
// there is no need to put a full barrier here.
#if V8_HOST_ARCH_IA32
ATOMICOPS_COMPILER_BARRIER();
#else
MemoryBarrier();
#endif
Or we can introduce an AcquireMemoryBarrier function that would have
the #if
ARCH.
Done.
https://codereview.chromium.org/694703003/diff/20001/src/base/atomicops_internals_mac.h#newcode191
src/base/atomicops_internals_mac.h:191: ATOMICOPS_COMPILER_BARRIER();
On 2014/11/05 11:54:53, jarin wrote:
As above, maybe we want
// On x86 processors, loads already have acquire semantics, so
// there is no need to put a full barrier here.
#if V8_HOST_ARCH_X64
ATOMICOPS_COMPILER_BARRIER();
#else
MemoryBarrier();
#endif
Done.
https://codereview.chromium.org/694703003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
