Reviewers: Benedikt Meurer, Jakob,
Message:
PTAL. This runs 2*9 tests now on tools/run-tests.py --arch ia32 --mode
release
mjsunit/asm/embenchen --time --report
The report still looks weird and says 0 tests are expected to pass... maybe
because it doesn't know that expectation...
Description:
Fix fast-variants feature in test driver.
BUG=
Please review this at https://codereview.chromium.org/701933003/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+13, -8 lines):
M tools/run-tests.py
M tools/testrunner/local/testsuite.py
Index: tools/run-tests.py
diff --git a/tools/run-tests.py b/tools/run-tests.py
index
dc73a4035fc364abbadb6ac23b5afeec3ee24ffd..20f36798a7ee71c4040956ed8cc9746a2afa7c7f
100755
--- a/tools/run-tests.py
+++ b/tools/run-tests.py
@@ -44,6 +44,7 @@ import time
from testrunner.local import execution
from testrunner.local import progress
from testrunner.local import testsuite
+from testrunner.local.testsuite import VARIANT_FLAGS
from testrunner.local import utils
from testrunner.local import verbose
from testrunner.network import network_execution
@@ -83,13 +84,6 @@ TIMEOUT_DEFAULT = 60
TIMEOUT_SCALEFACTOR = {"debug" : 4,
"release" : 1 }
-# Use this to run several variants of the tests.
-VARIANT_FLAGS = {
- "default": [],
- "stress": ["--stress-opt", "--always-opt"],
- "turbofan": ["--turbo-asm", "--turbo-filter=*", "--always-opt"],
- "nocrankshaft": ["--nocrankshaft"]}
-
VARIANTS = ["default", "stress", "turbofan", "nocrankshaft"]
MODE_FLAGS = {
Index: tools/testrunner/local/testsuite.py
diff --git a/tools/testrunner/local/testsuite.py
b/tools/testrunner/local/testsuite.py
index
24161f388862b757338faa23e890b8562fdf1585..6ff97b34b9e549162f8bebf2bdd23225782ae00e
100644
--- a/tools/testrunner/local/testsuite.py
+++ b/tools/testrunner/local/testsuite.py
@@ -34,6 +34,17 @@ from . import statusfile
from . import utils
from ..objects import testcase
+# Use this to run several variants of the tests.
+VARIANT_FLAGS = {
+ "default": [],
+ "stress": ["--stress-opt", "--always-opt"],
+ "turbofan": ["--turbo-asm", "--turbo-filter=*", "--always-opt"],
+ "nocrankshaft": ["--nocrankshaft"]}
+
+FAST_VARIANT_FLAGS = [
+ f for v, f in VARIANT_FLAGS.iteritems() if v in ["default", "turbofan"]
+]
+
class TestSuite(object):
@staticmethod
@@ -82,7 +93,7 @@ class TestSuite(object):
if testcase.outcomes and
statusfile.OnlyStandardVariant(testcase.outcomes):
return [[]]
if testcase.outcomes and
statusfile.OnlyFastVariants(testcase.outcomes):
- return filter(lambda v: v in ["default", "turbofan"], default_flags)
+ return filter(lambda flags: flags in FAST_VARIANT_FLAGS,
default_flags)
return default_flags
def DownloadData(self):
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
