On 2014/11/05 12:46:21, rossberg wrote:
https://codereview.chromium.org/699343004/diff/1/src/ast-value-factory.cc
File src/ast-value-factory.cc (left):
https://codereview.chromium.org/699343004/diff/1/src/ast-value-factory.cc#oldcode235
src/ast-value-factory.cc:235: return
GetOneByteString(content.ToOneByteVector());
On 2014/11/05 12:41:41, marja wrote:
> On 2014/11/05 12:39:51, rossberg wrote:
> > I'm confused, what's the reason to inline these functions? Unless I'm
missing
> > something, the code is identical.
>
> constness.
>
> Another option would be to make these API functions return AstRawString*
instead
> of const AstRawString* but that's also somewhat meh.
>
> (The users are anyway supposed to e.g., internalize the AstRawStrings
they
get,
> so returning const AstRawString* is more correct..)
Why not make the functions non-const but private, and have the public
ones be
thin const wrappers?
That would work too; see the latest patch set.
https://codereview.chromium.org/699343004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
