https://codereview.chromium.org/702843002/diff/1/tools/push-to-trunk/merge_to_branch.py
File tools/push-to-trunk/merge_to_branch.py (right):
https://codereview.chromium.org/702843002/diff/1/tools/push-to-trunk/merge_to_branch.py#newcode120
tools/push-to-trunk/merge_to_branch.py:120: self["full_revision_list"]))
On 2014/11/05 12:59:15, tandrii wrote:
I think this is shorter and more readable:
join(action_text % s for s in self["full_revision_list"])
Also, I don't like += to grow strings, though here it's arguably
justified.
Still, consider building self["new_commit_msg"] using a list of
strings, joined
at the end.
Done.
https://codereview.chromium.org/702843002/diff/1/tools/push-to-trunk/merge_to_branch.py#newcode132
tools/push-to-trunk/merge_to_branch.py:132: bugs.extend(map(lambda s:
s.strip(), bug.split(",")))
On 2014/11/05 12:59:15, tandrii wrote:
consider shorter:
bugs.extend(s.strip() for s in bug.split(","))
Done.
https://codereview.chromium.org/702843002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
