PTAL, now with feedback addressed and lots of tests
https://codereview.chromium.org/704713003/diff/160001/src/compiler/node-matchers.h
File src/compiler/node-matchers.h (right):
https://codereview.chromium.org/704713003/diff/160001/src/compiler/node-matchers.h#newcode184
src/compiler/node-matchers.h:184: bool IsScaledInput(Node* node) const {
On 2014/11/06 11:47:06, titzer wrote:
You could also have this method return the scaled power of 2, with -1
representing no match.
Done.
https://codereview.chromium.org/704713003/diff/160001/src/compiler/node-matchers.h#newcode320
src/compiler/node-matchers.h:320: bool Matches() const { return
matches_; }
On 2014/11/06 11:47:06, titzer wrote:
Lower case for simple getters.
Done.
https://codereview.chromium.org/704713003/diff/160001/src/compiler/x64/instruction-selector-x64.cc
File src/compiler/x64/instruction-selector-x64.cc (right):
https://codereview.chromium.org/704713003/diff/160001/src/compiler/x64/instruction-selector-x64.cc#newcode369
src/compiler/x64/instruction-selector-x64.cc:369: static AddressingMode
ScaleFactorToAddressingMode(
On 2014/11/06 11:47:06, titzer wrote:
If you use the scale power of 2, then you can just do a linear index
into this
array, then you can maybe even inline this method.
Done.
https://codereview.chromium.org/704713003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
