LGTM. I'll land it for you. The concerns about #ifs are mainly that you
construct a rather non-trivial hypercube of configurations without even
trying
to compile most of them. Similar things have hit us in the past in several
other
places, so consider yourself warned... :-D
https://codereview.chromium.org/571173003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.