On 2014/11/04 09:30:33, Toon Verwaest wrote:
lgtm
Alternatively you could precalculate at which limit you'll overflow
index-range,
and just have 2 loops. That would be a bit less costly, and rely less on
internal arrays behaving correctly.
Okay, dug out from the whirlwind of BlinkOn, and now I'm not sure what
you're
asking for. Are you suggesting to simply break when we hit the first key
that's
= 2^32 and then continue the loop after that? I think that'll require
pre-sorting the array keys, which we're not doing now, but we do that in
most
other places so it'd probably be fine. Or did you have something else in
mind?
https://codereview.chromium.org/679113003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
