lgtm with nits:
https://codereview.chromium.org/696783005/diff/40001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/696783005/diff/40001/src/code-stubs.h#newcode2041
src/code-stubs.h:2041: return lookup_result->context_index >= 0 &&
Suggestion: there is a BitField::is_valid() method which could be
convenient to use here.
https://codereview.chromium.org/696783005/diff/40001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/696783005/diff/40001/src/hydrogen.cc#newcode5380
src/hydrogen.cc:5380: Handle<GlobalContextTable> global_contexts(
It looks like this piece of code should be inside if
(FLAG_harmony_scoping...) block.
https://codereview.chromium.org/696783005/diff/40001/test/cctest/test-decls.cc
File test/cctest/test-decls.cc (right):
https://codereview.chromium.org/696783005/diff/40001/test/cctest/test-decls.cc#newcode892
test/cctest/test-decls.cc:892:
context.Check("%OptimizeFunctionOnNextCall(g); g()", EXPECT_RESULT,
What about also trying to optimize f() and g() before the "let x" script
to ensure that the optimized code does not stuck with the wrong x? Maybe
as another test.
https://codereview.chromium.org/696783005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
