On 2014/11/11 10:07:38, aandrey wrote:
https://codereview.chromium.org/701093003/diff/20001/test/mjsunit/regress/regress-crbug-109362.js
File test/mjsunit/regress/regress-crbug-109362.js (right):
https://codereview.chromium.org/701093003/diff/20001/test/mjsunit/regress/regress-crbug-109362.js#newcode14
test/mjsunit/regress/regress-crbug-109362.js:14: var g = new Function('\n
1 +
reference_error //@ sourceURL=evaltest');
I meant:
var g = eval('(function () {\n 1 + reference_error //@
sourceURL=evaltest\n})')
Otherwise, it is the same test case as above.
I'm asking because AFAIU this change will also affect eval(), which is
wrong.
I
think we should set -1 line offset only for new Function(), but not for
eval().
It won't affect eval, which doesn't pass true as second argument to
%CompileString. I added the suggested test.
However I reverted the change related to
%FunctionMarkNameShouldPrintAsAnonymous, because the function it should
mark is
a different one than what %CompileString returns. It should mark the
function
that is returned from executing the function returned by %CompileString.
https://codereview.chromium.org/701093003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
