Reviewers: Yang,
Message:
yangguo, ptal
Description:
Remove V8.ZoneSegmentBytes.
1) It's unused. 2) Since Zones can be used on a background thread, the Zone
cannot just access this counter from the Isolate, so keeping this counter
up to
date would require extra work. Better to just remove it.
BUG=431860
LOG=n
Please review this at https://codereview.chromium.org/716793002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -2 lines):
M src/counters.h
M src/zone-inl.h
Index: src/counters.h
diff --git a/src/counters.h b/src/counters.h
index
651cf54be9a69564b302cc9fb11459a4570ce91c..41107cfc33b8c944496e37d269c4ba647ad260fc
100644
--- a/src/counters.h
+++ b/src/counters.h
@@ -489,7 +489,6 @@ class HistogramTimerScope BASE_EMBEDDED {
SC(for_in,
V8.ForIn) \
SC(enum_cache_hits,
V8.EnumCacheHits) \
SC(enum_cache_misses,
V8.EnumCacheMisses) \
- SC(zone_segment_bytes,
V8.ZoneSegmentBytes) \
SC(fast_new_closure_total,
V8.FastNewClosureTotal) \
SC(fast_new_closure_try_optimized,
V8.FastNewClosureTryOptimized) \
SC(fast_new_closure_install_optimized,
V8.FastNewClosureInstallOptimized) \
Index: src/zone-inl.h
diff --git a/src/zone-inl.h b/src/zone-inl.h
index
cf037b59bc3db156147141a19de903179606b804..63efe16818d0add6813675a6fbdad3935279b096
100644
--- a/src/zone-inl.h
+++ b/src/zone-inl.h
@@ -31,7 +31,6 @@ bool Zone::excess_allocation() {
void Zone::adjust_segment_bytes_allocated(int delta) {
segment_bytes_allocated_ += delta;
-
isolate_->counters()->zone_segment_bytes()->Set(segment_bytes_allocated_);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
