Reviewers: Sven Panne,
Description:
Don't print inlined function ID in --trace-hydrogen
FunctionLiteral has two purposes: it is a unit of compilation, and it is
also an expression. Its id() is only for the latter purpose, used by
the continuation of the closure, not by the closure itself.
When we inline, we treat the FunctionLiteral as a unit of compilation,
not as an expression, and as such the FunctionLiteral doesn't have any
meaningful ID. The right thing to do is not to access the ID when
printing the hydrogen expression.
[email protected]
BUG=v8:3680
LOG=N
Please review this at https://codereview.chromium.org/716793003/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -2 lines):
M src/hydrogen-instructions.cc
Index: src/hydrogen-instructions.cc
diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc
index
1589066374be9d7f5337bd3200462b7aef2c291a..1ca1a881aaad80bab9d17ff0b99450a7c9457dfa
100644
--- a/src/hydrogen-instructions.cc
+++ b/src/hydrogen-instructions.cc
@@ -2662,8 +2662,7 @@ void HEnterInlined::RegisterReturnTarget(HBasicBlock*
return_target,
std::ostream& HEnterInlined::PrintDataTo(std::ostream& os) const { //
NOLINT
- return os << function()->debug_name()->ToCString().get()
- << ", id=" << function()->id().ToInt();
+ return os << function()->debug_name()->ToCString().get();
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
