Comments addressed, landing
https://codereview.chromium.org/712973002/diff/20001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/712973002/diff/20001/src/code-stubs-hydrogen.cc#newcode549
src/code-stubs-hydrogen.cc:549:
HObjectAccess::ForGlobalContext(context_index));
On 2014/11/11 14:17:06, Igor Sheludko wrote:
I think it is worth adding BuildGetGlobalContext() method and use it
here and in
LoadGlobalContextFieldStub.
Done.
https://codereview.chromium.org/712973002/diff/20001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/712973002/diff/20001/src/code-stubs.h#newcode2062
src/code-stubs.h:2062: virtual Code::Kind kind() const { return
Code::LOAD_IC; }
On 2014/11/11 12:37:39, rossberg wrote:
OVERRIDE?
Done.
https://codereview.chromium.org/712973002/diff/20001/src/code-stubs.h#newcode2075
src/code-stubs.h:2075: virtual Code::Kind kind() const { return
Code::STORE_IC; }
On 2014/11/11 12:37:39, rossberg wrote:
OVERRIDE?
Done.
https://codereview.chromium.org/712973002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
