Revision: 25267
Author: [email protected]
Date: Tue Nov 11 15:53:42 2014 UTC
Log: Don't print inlined function ID in --trace-hydrogen
FunctionLiteral has two purposes: it is a unit of compilation, and it is
also an expression. Its id() is only for the latter purpose, used by
the continuation of the closure, not by the closure itself.
When we inline, we treat the FunctionLiteral as a unit of compilation,
not as an expression, and as such the FunctionLiteral doesn't have any
meaningful ID. The right thing to do is not to access the ID when
printing the hydrogen expression.
[email protected], [email protected]
BUG=v8:3680
LOG=N
Review URL: https://codereview.chromium.org/716793003
https://code.google.com/p/v8/source/detail?r=25267
Modified:
/branches/bleeding_edge/src/hydrogen-instructions.cc
=======================================
--- /branches/bleeding_edge/src/hydrogen-instructions.cc Tue Nov 11
11:16:30 2014 UTC
+++ /branches/bleeding_edge/src/hydrogen-instructions.cc Tue Nov 11
15:53:42 2014 UTC
@@ -2662,8 +2662,7 @@
std::ostream& HEnterInlined::PrintDataTo(std::ostream& os) const { //
NOLINT
- return os << function()->debug_name()->ToCString().get()
- << ", id=" << function()->id().ToInt();
+ return os << function()->debug_name()->ToCString().get();
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
