Comment #3 on issue 3680 by [email protected]: --trace-hydrogen is broken in Debug mode
https://code.google.com/p/v8/issues/detail?id=3680#c3

The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/5044c510cb6773bcd518da6add2588cb973d8724

commit 5044c510cb6773bcd518da6add2588cb973d8724
Author: [email protected] <[email protected]>
Date: Tue Nov 11 15:53:42 2014

Don't print inlined function ID in --trace-hydrogen

FunctionLiteral has two purposes: it is a unit of compilation, and it is
also an expression.  Its id() is only for the latter purpose, used by
the continuation of the closure, not by the closure itself.

When we inline, we treat the FunctionLiteral as a unit of compilation,
not as an expression, and as such the FunctionLiteral doesn't have any
meaningful ID.  The right thing to do is not to access the ID when
printing the hydrogen expression.

[email protected], [email protected]
BUG=v8:3680
LOG=N

Review URL: https://codereview.chromium.org/716793003

Cr-Commit-Position: refs/heads/master@{#25267}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25267 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

[modify] https://chromium.googlesource.com/v8/v8.git/+/5044c510cb6773bcd518da6add2588cb973d8724/src/hydrogen-instructions.cc


--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to