On 2014/11/11 14:16:09, Yang wrote:
On 2014/11/11 14:01:12, aandrey wrote:
> On 2014/11/11 13:49:14, Yang wrote:
> > https://codereview.chromium.org/711353002/diff/1/include/v8.h
> > File include/v8.h (right):
> >
> >
https://codereview.chromium.org/711353002/diff/1/include/v8.h#newcode4192
> > include/v8.h:4192: static Local<StackTrace>
GetStackTrace(Handle<Value>
> > exception);
> > On 2014/11/11 10:54:07, aandrey wrote:
> > > This method will be used by inspector as it's not equal to
> > > CreateMessage()->GetStackTrace().
> >
> > Can you elaborate why the inspector can't use
> CreateMessage()->GetStackTrace()?
> >
> > Wasn't the plan to have that replace Exception::GetStackTrace()this by
> > CreateMessage()->GetStackTrace()? The former has no test coverage in
V8 at
> all.
>
> We will need to get a detailed stack from an error object, if it's
there.
> CreateMessage()->GetStackTrace() will create current stack trace, it the
stack
> not available (for example, if not an error object).
> We'll want to restore stack traces for certain console messages upon
opening
> DevTools, and obviously we don't want to assign current stack trace for
those
> messages.
>
> Added test cases.
LGTM if you add what you just explained as comment to both methods.
Added the comments.
https://codereview.chromium.org/711353002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
