[email protected] To have CHECK_EQ for both 32-bit and 64-bit ints, we need to handle the following cases, on both 32- and 64- bit platforms: Comparing int32_t to uint32_t, where we want to reinterpret them as both int32_t Comparing int32_t to intptr_t - this would need explicit casts in all cases. Comparing int64_t to intptr_t
So I think a separate CHECK_INT64_EQ is safer than overloading, or having only a 64-bit CHECK_EQ, with all integer types upconverted (that breaks comparisons between int32_t and uint32_t that want to reinterpret then as 32-bit patterns). http://codereview.chromium.org/256048 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
