LGTM with some nits in the tests; please add an OWNER :)
https://codereview.chromium.org/660863003/diff/20001/test/mjsunit/harmony/typedarrays-of.js
File test/mjsunit/harmony/typedarrays-of.js (right):
https://codereview.chromium.org/660863003/diff/20001/test/mjsunit/harmony/typedarrays-of.js#newcode36
test/mjsunit/harmony/typedarrays-of.js:36: assertEquals(true, !!a[3]);
just assert that a[3] is 1; more direct. likewhere with a[4] and 0, and
below in the other case.
https://codereview.chromium.org/660863003/diff/20001/test/mjsunit/harmony/typedarrays-of.js#newcode38
test/mjsunit/harmony/typedarrays-of.js:38: assertEquals(true, (a[5] -
3.14) < 1e-6);
this needs abs()
https://codereview.chromium.org/660863003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
