Thanks a lot, Lasse. Currently those changes are just undone, but I'll use proper cast when redoing it.
yours, anton. On Sat, Oct 3, 2009 at 12:01 AM, <[email protected]> wrote: > Drive by comments. > > > http://codereview.chromium.org/256041/diff/1/2 > File test/cctest/test-api.cc (right): > > http://codereview.chromium.org/256041/diff/1/2#newcode706 > Line 706: # define CAST_TO_INT64(x) (int(x)) > It seems counter-intuitive to have a macro called CAST_TO_INT64 that > casts to a 32-bit integer type. > > I'd prefer CAST_TO_V8_INTEGER_VALUE (since it seems it casts to the > return type of Integer::Value). > > I'd prefer C++ style casts, i.e., static_cast<int>(x). > > http://codereview.chromium.org/256041 > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
