Revision: 25293
Author:   [email protected]
Date:     Wed Nov 12 12:23:13 2014 UTC
Log: Disable top level serialization under harmony_scoping. It has broken tests.

[email protected]

Review URL: https://codereview.chromium.org/717143002
https://code.google.com/p/v8/source/detail?r=25293

Modified:
 /branches/bleeding_edge/src/compiler.cc

=======================================
--- /branches/bleeding_edge/src/compiler.cc     Wed Nov 12 11:34:09 2014 UTC
+++ /branches/bleeding_edge/src/compiler.cc     Wed Nov 12 12:23:13 2014 UTC
@@ -1243,7 +1243,9 @@
     result = CompileToplevel(&info);
     if (extension == NULL && !result.is_null() && !result->dont_cache()) {
       compilation_cache->PutScript(source, context, result);
-      if (FLAG_serialize_toplevel &&
+      // TODO(dslomov): Issue 3628.
+      // Reenable when harmony scoping serialization issues are fixed.
+      if (FLAG_serialize_toplevel && !FLAG_harmony_scoping &&
           compile_options == ScriptCompiler::kProduceCodeCache) {
         HistogramTimerScope histogram_timer(
             isolate->counters()->compile_serialize());

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to